Add prove_leaf_from_files to the leaf prover#390
Conversation
PR SummaryLow Risk Overview Program input loading now uses Reviewed by Cursor Bugbot for commit df9e302. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## yairv/add_multiverifier_support_for_recursive_tree_prover #390 +/- ##
=============================================================================================
+ Coverage 65.10% 65.25% +0.15%
=============================================================================================
Files 45 45
Lines 5834 5843 +9
=============================================================================================
+ Hits 3798 3813 +15
+ Misses 2036 2030 -6
🚀 New features to boost your workflow:
|
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).
2e7f0ae to
083dd1a
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).
A file-path front end of `prove_leaf`: loads the compiled program, program input, and both prover parameter JSONs from disk. The binary's `main` is deduplicated onto it, and tests that drive the leaf prover end-to-end (the recursive tree's golden e2e, added separately) call it directly. No behavior change on the happy path. The `get_program_input_from_path` error arm is dropped as dead code (the function is infallible — it only wraps the path; the file is read inside the run). The reachable failure paths (each missing input file panics with its descriptive message) are covered by fast `should_panic` tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
083dd1a to
df9e302
Compare
66e3666 to
270e1b8
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on YairVaknin-starkware).
crates/leaf_prover/tests/prove_leaf_from_files_test.rs line 40 at r3 (raw file):
&test_data_dir().join("no_such_params.json"), ); }
And another test that actually proves?
A file-path front end of
prove_leaf: loads the compiled program, program input, and both prover parameter JSONs from disk. The binary'smainis deduplicated onto it, and tests that drive the leaf prover end-to-end (the recursive tree's golden e2e, added later in this stack) call it directly.No behavior change on the happy path. The
get_program_input_from_patherror arm is dropped as dead code (the function is infallible — it only wraps the path; the file is read inside the run). The reachable failure paths (each missing input file panics with its descriptive message) are covered by fastshould_panictests.Stack (1/4): this ← retarget canonical (#391) ← PackedNode roots (#392) ← goldens e2e (#388).
🤖 Generated with Claude Code
This change is