Update rubocop to 1.86.1 and standard-performance to 1.9.0#806
Closed
camilopayan wants to merge 2 commits into
Closed
Update rubocop to 1.86.1 and standard-performance to 1.9.0#806camilopayan wants to merge 2 commits into
camilopayan wants to merge 2 commits into
Conversation
Co-Authored-By: Camilo Payan <camilo.payan@testdouble.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates RuboCop from 1.84.0 to 1.86.1.
Updates standard-performance to 1.9.0.
New cops
These cops were added and need a configuration decision before tests will pass:
Lint/DataDefineOverrideData.defineoverriding existing methods.Lint/UnreachablePatternBranchcaseexpressions.Style/FileOpenFile.openwithout a block.Style/MapJoinmap { ... }.joinand suggestsmap_joinor efficient alternatives.Style/OneClassPerFileStyle/PartitionInsteadOfDoubleSelectselectcalls that can be replaced withpartition.Style/PredicateWithKindkind_of?oris_a?.Style/ReduceToHashreduceorinjectused to build a hash.Style/RedundantMinMaxBymin_byormax_bycalls.Style/RedundantStructKeywordInitkeyword_init: trueinStruct.new.Style/SelectByKindselectcalls that can be replaced withgrep.Style/SelectByRangeselectcalls that can be replaced with range slicing.Style/TallyMethodEnumerable#tally.Style/EmptyClassDefinitionStyle/HashLookupMethodHash#[]andHash#fetch.Changed cops
These existing cops had behavioral changes:
Style/OneClassPerFilespec/**/*andtest/**/*by default.Style/RedundantStructKeywordInitStyle/EndlessMethodStyle/RedundantInterpolationUnfreezeString.newwith interpolated strings.Style/RedundantParenthesesThe
config/YAML files have not been updated for any of the above cops.Tests are expected to fail until those configurations are added in a follow-up.