Skip to content

fix: correct toNum 64-bit conversion and deduplicate #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fayekelmith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct toNum 64-bit conversion and deduplicate #1480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions mcp/src/benchmark/sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Request, Response } from "express";
import { existsSync, readdirSync, readFileSync, statSync } from "fs";
import path from "path";
import { db } from "../graph/neo4j.js";
import { toNum } from "../graph/types.js";
import {
loadStepMeta,
loadSearchProvenance,
Expand Down Expand Up @@ -140,13 +141,6 @@ function parseSessionMessages(filePath: string): {
};
}

function toNum(v: any): number {
if (v == null) return 0;
if (typeof v === "object" && typeof v.toNumber === "function")
return v.toNumber();
return Number(v) || 0;
}

function calcCost(
model: string,
providerHint: string,
Expand Down
11 changes: 4 additions & 7 deletions mcp/src/graph/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export interface Node {
node_data: NodeData;
}

export type BoltInt = number | { low: number; hight: number };
export type BoltInt = number | { low: number; high: number };

export interface Neo4jNode {
identity?: BoltInt; // built-in on some queries
Expand Down Expand Up @@ -330,12 +330,9 @@ export function normalizeNodeType(label: string): NodeType | undefined {
}

export function toNum(bi: BoltInt): number {
if (typeof bi === "object") {
if (bi.low) {
return bi.low;
}
} else {
return bi;
if (typeof bi === "number") return bi;
if (bi && typeof bi.low === "number") {
return (bi.high ?? 0) * 2 ** 32 + (bi.low >>> 0);
}
return 0;
}
Expand Down
Loading