fix(iaas): print valid JSON/YAML output for list cmds#1365
Open
j1n-o9r wants to merge 9 commits intostackitcloud:mainfrom
Open
fix(iaas): print valid JSON/YAML output for list cmds#1365j1n-o9r wants to merge 9 commits intostackitcloud:mainfrom
j1n-o9r wants to merge 9 commits intostackitcloud:mainfrom
Conversation
… any items via outputResult function instead of returning nil bluntly. adapted tests therefore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-241 / #893
Testing Instructions
stackit server list-> Expected: No servers found for project "xxx"stackit server list --output-format json-> Should output valid JSONstackit server list --output-format yaml-> Should output valid YAMLstackit network list-> Expected: No networks found for project "xxx"stackit network list --output-format json-> Should output valid JSONstackit network list --output-format yaml-> Should output valid YAMLstackit network-area list --organization-id xxx-> Expected: No servers found for project "xxx"stackit network-area list --organization-id xxx --output-format json-> Should output valid JSONstackit network-area list --organization-id xxx --output-format yaml-> Should output valid YAMLstackit network create --name xxxstackit network-interface list --network-id yyy-> Expected: No network-interface found for project "xxx"stackit network-interface list --network-id yyy --output-format json-> Should output valid JSONstackit network-interface list --network-id yyy --output-format yaml-> Should output valid YAMLChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)