Refactor/remove separate merge mechanism#792
Open
siegfriedweber wants to merge 2 commits into
Open
Conversation
maltesander
reviewed
Jun 11, 2026
Comment on lines
+785
to
792
| #[allow(unused)] | ||
| pub fn as_journalnode(&self) -> Option<&JournalNodeConfig> { | ||
| if let Self::Journal(node) = self { | ||
| Some(node) | ||
| } else { | ||
| None | ||
| } | ||
| } |
| @@ -0,0 +1,54 @@ | |||
| use crate::{ | |||
Member
There was a problem hiding this comment.
In crd/mod.rs is a private test method datanode_pvc. Do we want to move that here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the framework module and the separate merging mechanism.
This was made possible with stackabletech/operator-rs#1220 which provides mergeable
JvmArgumentOverrides.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker