fix: pr-bug-scan validated finding from #4499#4739
Open
buf0-bot[bot] wants to merge 1 commit into
Open
Conversation
Restore continueOnSaveFailure branch in prepareRendererForAppRestart; updater.quitAndInstall now logs and proceeds when hot-exit backup rejects.
Contributor
There was a problem hiding this comment.
Reviewed changes — restores a continueOnSaveFailure bypass in the hot-exit backup path so that quitAndInstall proceeds even when editor-state backup fails, preventing a downloaded update from getting stuck behind unrecoverable editor state.
- Add
continueOnSaveFailure/saveFailureLogPrefixtoAppRestartPrepOptions— optional fields that let callers control whether backup failures abort the restart. - Guard the abort/rethrow in
prepareRendererForAppRestartbehindcontinueOnSaveFailure— when the flag is set, aconsole.warnreplaces the abort path. - Wire
quitAndInstallto continue on save failure — passescontinueOnSaveFailure: trueand a descriptive log prefix so the update install isn't blocked. Theapp.restartpath remains unmodified and still aborts on failure.
✅ No new issues found.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Automated fix-PR from pr-bug-scan for parent #4499.
Fixer status:
FIXED_WITH_CODE_PROOFSummary: Restore continueOnSaveFailure branch in prepareRendererForAppRestart; updater.quitAndInstall now logs and proceeds when hot-exit backup rejects.
Blocked proof link:
src/preload/index.ts:209-212 prepareRendererForAppRestart re-throws on requestEditorHotExitBackup rejectionTypecheck:
skippedProof (from validator)
code_analysiscode_analysisGenerated by
pr-bug-scan(proof-machine architecture). Human approval required before merge.