fix: pr-bug-scan validated finding from #4580#4738
Open
buf0-bot[bot] wants to merge 1 commit into
Open
Conversation
Tag cached ignoredPaths with their (worktreeId, worktreePath) source key; effectiveIgnoredPaths returns empty when the cached key doesn't match the current worktree.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — keys ignoredPaths state by worktree identity so effectiveIgnoredPaths returns empty when the cached state doesn't belong to the current worktree, preventing stale gitignore patterns from the previous worktree from leaking into the file explorer during a worktree switch.
- Tag
ignoredPathsstate with a worktree source key —ignoredPathsStatenow carries asourceKey(${activeWorktreeId}\n${worktreePath}) alongside the paths array, andeffectiveIgnoredPathsgates its read onsourceKeyequality.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Automated fix-PR from pr-bug-scan for parent #4580.
Fixer status:
FIXED_WITH_CODE_PROOFSummary: Tag cached ignoredPaths with their (worktreeId, worktreePath) source key; effectiveIgnoredPaths returns empty when the cached key doesn't match the current worktree.
Blocked proof link:
src/renderer/src/components/right-sidebar/useFileExplorerGitIgnoredRows.ts:75 — effectiveIgnoredPaths now returns EMPTY_IGNORED_PATHS when the cached state's sourceKey does not equal the current worktree's sourceKey, so on canLoadIgnoredPaths false→true into a new worktree the prior worktree's ignoredPaths can no longer be read.Typecheck:
skippedProof (from validator)
code_analysisGenerated by
pr-bug-scan(proof-machine architecture). Human approval required before merge.