fix: pr-bug-scan validated finding from #4449#4734
Open
buf0-bot[bot] wants to merge 1 commit into
Open
Conversation
Restore track() calls for contextual_tour_shown/outcome (re-imports track) so events reach product analytics; new setup_guide_*/terminal_pane_split events stay in validation log per design.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — restores track() calls for contextual_tour_shown and contextual_tour_outcome so these events reach the product analytics pipeline instead of being logged to console only.
- Switch
trackContextualTourShownandtrackContextualTourOutcomefromlogFeatureEducationTelemetrytotrack— the two functions now correctly route through the product telemetry pipeline. Other feature-education events (setup_guide_*,terminal_pane_split) remain on the validation-onlylogFeatureEducationTelemetrypath. - Update tests to assert against
trackMock— two test cases fortrackContextualTourOutcomenow verifytrackMockcalls and drop the priorexpect(trackMock).not.toHaveBeenCalled()assertions.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Automated fix-PR from pr-bug-scan for parent #4449.
Fixer status:
FIXED_WITH_CODE_PROOFSummary: Restore track() calls for contextual_tour_shown/outcome (re-imports track) so events reach product analytics; new setup_guide_*/terminal_pane_split events stay in validation log per design.
Blocked proof link:
src/renderer/src/lib/feature-education-telemetry.ts:35 trackContextualTourShown and :47 trackContextualTourOutcome now call track() instead of logFeatureEducationTelemetry, so the call sites at ContextualTourOverlay.tsx:251 and :92 once again ship to PostHogTypecheck:
skippedProof (from validator)
code_analysisGenerated by
pr-bug-scan(proof-machine architecture). Human approval required before merge.