Skip to content

fix: pr-bug-scan validated finding from #4449#4734

Open
buf0-bot[bot] wants to merge 1 commit into
mainfrom
bot/pr-bug-scan-4449-1780717953
Open

fix: pr-bug-scan validated finding from #4449#4734
buf0-bot[bot] wants to merge 1 commit into
mainfrom
bot/pr-bug-scan-4449-1780717953

Conversation

@buf0-bot
Copy link
Copy Markdown
Contributor

@buf0-bot buf0-bot Bot commented Jun 6, 2026

Automated fix-PR from pr-bug-scan for parent #4449.

Fixer status: FIXED_WITH_CODE_PROOF
Summary: Restore track() calls for contextual_tour_shown/outcome (re-imports track) so events reach product analytics; new setup_guide_*/terminal_pane_split events stay in validation log per design.
Blocked proof link: src/renderer/src/lib/feature-education-telemetry.ts:35 trackContextualTourShown and :47 trackContextualTourOutcome now call track() instead of logFeatureEducationTelemetry, so the call sites at ContextualTourOverlay.tsx:251 and :92 once again ship to PostHog
Typecheck: skipped

Proof (from validator)

  • C1 — proof_type: code_analysis
    • trigger: Any contextual tour render or outcome (e.g. workspace-agent-sessions auto-tour, setup_guide_parallel_work tour) fires after this PR is merged
    • observable: contextual_tour_shown and contextual_tour_outcome events no longer reach the product telemetry pipeline; PostHog event volume for these names drops to zero after the merge
    • path:
      • src/renderer/src/components/contextual-tours/ContextualTourOverlay.tsx:251 calls trackContextualTourShown
      • src/renderer/src/components/contextual-tours/ContextualTourOverlay.tsx:92 calls trackContextualTourOutcome
      • src/renderer/src/lib/feature-education-telemetry.ts:35 trackContextualTourShown body now calls logFeatureEducationTelemetry, not track
      • src/renderer/src/lib/feature-education-telemetry.ts:53 trackContextualTourOutcome body now calls logFeatureEducationTelemetry, not track
      • src/renderer/src/lib/feature-education-telemetry.ts (logFeatureEducationTelemetry) only console.info's; never invokes track()

Generated by pr-bug-scan (proof-machine architecture). Human approval required before merge.

Restore track() calls for contextual_tour_shown/outcome (re-imports track) so events reach product analytics; new setup_guide_*/terminal_pane_split events stay in validation log per design.
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — restores track() calls for contextual_tour_shown and contextual_tour_outcome so these events reach the product analytics pipeline instead of being logged to console only.

  • Switch trackContextualTourShown and trackContextualTourOutcome from logFeatureEducationTelemetry to track — the two functions now correctly route through the product telemetry pipeline. Other feature-education events (setup_guide_*, terminal_pane_split) remain on the validation-only logFeatureEducationTelemetry path.
  • Update tests to assert against trackMock — two test cases for trackContextualTourOutcome now verify trackMock calls and drop the prior expect(trackMock).not.toHaveBeenCalled() assertions.

Pullfrog  | View workflow run | Using DeepSeek Pro (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants