fix: pr-bug-scan validated finding from #4462#4733
Open
buf0-bot[bot] wants to merge 1 commit into
Open
Conversation
Race git fetch in refreshBranchCleanupTargetRefs against a 5s timeout so worktree.rm cannot stall on unreachable remotes.
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — races git fetch --prune in refreshBranchCleanupTargetRefs against a 5s timeout so an unreachable remote cannot stall worktree.rm.
- Add
Promise.racetimeout torefreshBranchCleanupTargetRefs— thegit fetch --prunefor refreshing remotes before branch-cleanup now times out at 5s viaPromise.race, with the timer cleaned up in afinallyblock.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Automated fix-PR from pr-bug-scan for parent #4462.
Fixer status:
FIXED_WITH_CODE_PROOFSummary: Race git fetch in refreshBranchCleanupTargetRefs against a 5s timeout so worktree.rm cannot stall on unreachable remotes.
Blocked proof link:
src/shared/git-branch-cleanup.ts:61Typecheck:
skippedProof (from validator)
code_analysisGenerated by
pr-bug-scan(proof-machine architecture). Human approval required before merge.