Fix Codex held-key input batching#4732
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — this PR shortens the latency-sensitive foreground coalesce delay from 32ms to 16ms so held key repeats (ticking every 30–50ms) don't batch two redraw frames behind the fallback timer.
- Reduce
LATENCY_SENSITIVE_FOREGROUND_COALESCE_DELAY_MSfrom 32 to 16 — the new value is one frame at 60fps, shorter than the minimum key-repeat interval, so each repeat gets its ownxterm.writeinstead of coalescing two into one batch. - Update two existing test time advances — 31ms assertions changed to 15ms to stay just below the new 16ms threshold.
- Add regression test — "does not batch repeated latency-sensitive synchronized frames across key-repeat ticks" enqueues two Codex-style frame pairs and verifies two separate writes with the correct data.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Repro / validation
Note: local electron-builder --dir produced dist-held-key-fix/win-unpacked and then hit the known Windows winCodeSign symlink extraction failure.