(WIP) Bedrock Linux Support - #59
Conversation
|
What is in the |
|
I was thinking of adding a CMake option for each distro but my PR was closed. |
|
@sam-barr that shows what bedrock linux version you're on. /etc/os-release shows the default linux distro running over top of bedrock linux. |
|
@otreblan I don't think that's related to this PR though. Maybe put that in Issues? |
|
@sam-barr have any idea how I could implement multiple logos in the main function? |
|
As it stands now the logo is decided at compile time, and I'm not really looking to change that behavior at the moment. allisio (not sure how to tag them in this) has written some stuff w.r.t package managers which includes logic based on the distro. If/when they make a pull request with that this extra business with bedrock linux could probably be added onto that. |
|
My current code seems to not work. It compiles, but when I run it, it crashes. Can anyone else reproduce the issue? is it a simple mistake? I am new to C |
|
wrong button, lol |
|
So the logo part is still not working and I think it get's quite complicated and needs rethinking and some code changes. Maybe it would be best to narrow this pull request down to only add the bedrock name stuff and tackle the integration of other logos later? |
|
Would I just close the PR and create 2 new ones? |
|
Has anyone figured out how the logo can be decided on run time? |
|
I really want multi-os support! |
|
Bump. Anyone think of any ideas to fix this issue? |
|
|
|
|
|
Oh cool! Thanks for the info! |
|
can someone check out my code so far? it works for me. |
|
Right now, my branch is about 10x slower than the master branch. It's all mostly due to package manager recognition. |
|
When you enable caching the package info, paleofetch becomes about the same speed as the master branch. |
|
One thing I found is that if I have 2 statums (on bedrock linux) of distros that use the same package manager, it only uses one of them to do the count. |
|
Caching the package count probably shouldn't be the default behavior. It's a dynamic value that changes pretty often. |
|
Yea, but paleofetch is super slow when you don't. I'm getting about 8-20 ms w/ caching, and 400-600 ms w/o caching. |
|
Then you're essentially breaking the build. Just my two cents. |
|
There has to be a faster way of looking for packages. Like paleofetch, is slow, not at the same level as neofetch, but slow nonetheless. |
|
Maybe it can be parallelized? |
Titaniumtown
changed the title
|
In the packages branch, @allisio and I implemented querying the package database in parallel, you might be able to look at that for ideas. |
|
I just pushed a commit, it seems not to run, anyone know why? It's something to do with the logo. |
|
Currently it compiles correctly, everything is in place except for the LOGO variable being set per-OS. |
|
Maybe this PR could just be about multiple package managers? |
|
Oh, almost forgot. I need to add support for multiple stratums that use the same package manager. ex ubuntu 2004 and ubuntu 1804 |
|
Does anyone have any ideas on how to fix the issue with having multiple logos? |
|
Hmm. Where is the LOGO string actually declared? We could replace that declaration with a function that first checks if the user has specified a logo, then if they have not, check a file like /etc/os-release to declare the logo? |
6 participants
Ok, I am new to C so be easy on me (that's also why my code is messy), lol. I did everything to add bedrock linux support, but I just don't now how I could implement multiple logos with the main function in paleofetch.c help needed!
I also stole the ascii art from neofetch.