Skip to content

добавил атронав в базовый кпк - #39

Open
Ledniky wants to merge 1 commit into
ss14-art:masterfrom
Ledniky:addAstroNav
Open

добавил атронав в базовый кпк#39
Ledniky wants to merge 1 commit into
ss14-art:masterfrom
Ledniky:addAstroNav

Conversation

@Ledniky

@Ledniky Ledniky commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

#21

Summary by CodeRabbit

  • New Features
    • Base PDAs now include AstroNav by default.
    • Passenger PDAs now provide access to crew manifests, notes, tasks, and news through preinstalled cartridges.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

PDA prototypes are updated to preload AstroNav on BasePDA, and PassengerPDA now includes a configured cartridge loader with crew, notes, tasks, and news cartridges.

Changes

PDA cartridge configuration

Layer / File(s) Summary
PDA preinstalled cartridge configuration
Resources/Prototypes/Entities/Objects/Devices/pda.yml
BasePDA preinstalls AstroNavCartridge, and PassengerPDA gains a CartridgeLoader with PdaUiKey.Key and four preinstalled cartridges.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: rewafflution

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main gameplay change: adding Astronav to the base PDA.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.45.0)

ast-grep could not parse rule config: /ast-grep-rules/../git/.ast-grep/rules/ss14-raw-string-popup.yml


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/Entities/Objects/Devices/pda.yml`:
- Line 89: Move the fork-specific AstroNavCartridge PDA configuration from the
upstream prototype into the corresponding Resources/Prototypes/_Art/ override,
including the additionally referenced changes around lines 186-192. If any
upstream edits must remain, wrap each one with the YAML ss14-art edit marker
syntax.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a91f9c3c-8535-4382-bc93-03ca4bfd4206

📥 Commits

Reviewing files that changed from the base of the PR and between 1a19fc6 and 7b224f4.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Objects/Devices/pda.yml

- NotekeeperCartridge
- NanoTaskCartridge
- NewsReaderCartridge
- AstroNavCartridge

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Keep fork changes out of the upstream prototype and mark unavoidable edits.

This file is outside Resources/Prototypes/_Art/, but the changed lines are unmarked. Move fork-specific PDA configuration into an _Art override; if an upstream edit is unavoidable, wrap it with the YAML ss14-art edit marker syntax.

Also applies to: 186-192

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/Entities/Objects/Devices/pda.yml` at line 89, Move the
fork-specific AstroNavCartridge PDA configuration from the upstream prototype
into the corresponding Resources/Prototypes/_Art/ override, including the
additionally referenced changes around lines 186-192. If any upstream edits must
remain, wrap each one with the YAML ss14-art edit marker syntax.

Sources: Coding guidelines, Path instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Нужно сделать

Development

Successfully merging this pull request may close these issues.

1 participant