Skip to content

Add app icons for multiple sizes and update Contents.json - #19

Open
DinanathDash wants to merge 1 commit into
srimanachanta:mainfrom
DinanathDash:feat/add-app-icons
Open

Add app icons for multiple sizes and update Contents.json#19
DinanathDash wants to merge 1 commit into
srimanachanta:mainfrom
DinanathDash:feat/add-app-icons

Conversation

@DinanathDash

Copy link
Copy Markdown
Contributor

This pull request updates the app icon assets for the macOS version of the project. The main change is the addition of new icon image files at various sizes and scales to the asset catalog, ensuring full support for all required macOS icon resolutions.

Asset updates:

  • Added new icon image files (AppIcon-16.png, AppIcon-32.png, AppIcon-32 1.png, AppIcon-64.png, AppIcon-128.png, AppIcon-256.png, AppIcon-256 1.png, AppIcon-512 1.png, AppIcon-512.png, AppIcon-1024.png) to the AppIcon.appiconset for macOS, covering all necessary sizes and scales.

Closes #10

@DinanathDash

Copy link
Copy Markdown
Contributor Author

"Hey! @srimanachanta Just a quick heads-up: I've submitted 6 modular PRs (PRs #17 through #22) to break down a larger set of features and make the review process much easier for you.

Because a few of these PRs touch the same core files (like MenuViewModel.swift and BatteryIndicatorView.swift), merging one might cause merge conflicts in the others. Please review and merge them in whatever order makes the most sense to you!

Once you merge a PR, if GitHub flags any of my remaining open PRs with conflicts, just let me know or leave them be—I will actively monitor the repo and locally rebase my remaining branches against your updated main to resolve the conflicts for you. You won't have to resolve the conflicts yourself!
For the easiest path with the least overlap, my suggested review/merge order is:

  1. Fix Homebrew install command by removing --no-quarantine flag #21 (Fix Homebrew install) - Standalone.
  2. Add app icons for multiple sizes and update Contents.json #19 (App icons) - Standalone.
  3. Refactor time remaining calculation and integrate estimator #18 (Refactor time remaining)
  4. Add battery percentage display option in menu bar icon #17 (Battery percentage in menu bar)
  5. feat: reflect Low Power Mode in the menu bar battery icon #22 (Low Power Mode icon) - builds slightly on the view from Add battery percentage display option in menu bar icon #17.
  6. Add outgoing power visualization to Sankey diagram #20 (Outgoing power Sankey diagram) - heaviest changes.

Thanks for maintaining Stasis! Let me know if you need any adjustments.

@srimanachanta

Copy link
Copy Markdown
Owner

Hey @DinanathDash thanks for all of the MRs, im looking through them all now. For this one, I'm aganist using an AI generated Icon for the main app icon. Given its purely a utility app, creating an icon for it isnt a massive priority for me. If users really want an icon, they can do something like this.

@DinanathDash

Copy link
Copy Markdown
Contributor Author

Hey @DinanathDash thanks for all of the MRs, im looking through them all now. For this one, I'm aganist using an AI generated Icon for the main app icon. Given its purely a utility app, creating an icon for it isnt a massive priority for me. If users really want an icon, they can do something like this.

Hi @srimanachanta , I think you have mistaken about AI generated icon, this was purely designed by me in the figma.

No worries, I have just tried it. It's completely up to you, for my use case I'm already using it, so nothing personal at all. Cheers.

@srimanachanta

Copy link
Copy Markdown
Owner

Hey @DinanathDash thanks for all of the MRs, im looking through them all now. For this one, I'm aganist using an AI generated Icon for the main app icon. Given its purely a utility app, creating an icon for it isnt a massive priority for me. If users really want an icon, they can do something like this.

Hi @srimanachanta , I think you have mistaken about AI generated icon, this was purely designed by me in the figma.

No worries, I have just tried it. It's completely up to you, for my use case I'm already using it, so nothing personal at all. Cheers.

Sorry my mistake. Can you include the vector source files for it. I don't really see the connection to battery management with the color scheme within the icon.

@DinanathDash

Copy link
Copy Markdown
Contributor Author

Yeah I understand that there's no connection for the colour scheme and the app, because I have tried it to be different rest all the battery management apps, they all the have the same green coloured battery vector with some icons on top of it. So I choose this over the generic ones.

Here is the file it self:
Stasis Figma file

Stasis.fig.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add app icon

2 participants