fix(agent): FIM baseline advanced for unreported change deltas - #31
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(agent): FIM baseline advanced for unreported change deltas#31cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
When fim_max_changes (or the 1.5MiB transport trim) dropped change events, collectFIMChanges still merged the full scan into the baseline, so overflowed adds/modifies/deletes were never emitted on later scans. Only acknowledge reported paths (and unchanged/first-visit seeds); allow a re-commit after transport truncation. Co-authored-by: Ethan <sreyun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Full-scope FIM permanently lost change events whenever a scan produced more deltas than
fim_max_changes(default 500), or when the ~1.5MiB report marshal trimmedfile_changesfurther. Overflowed adds/modifies/deletes were merged into the on-disk baseline anyway, so later scans treated them as already acknowledged and never emitted them.Trigger: mass package update, bulk delete, or large config rollout on a host with FIM full scope enabled → first scan reports ≤500 changes (or ≤200 after size trim) and silently drops the rest forever.
Root cause
collectFIMChangestruncated the reported slice infimDiffBaseline, then advanced the baseline with the fullcurmap and every visited deletion. The transport size cap inmodule_host_security.gocould drop even more entries after that save.Fix
Validation
go test -count=1 -run 'TestCollectFIM|TestFIM|TestFim' ./cmd/agent/go build ./cmd/agent ./cmd/serverNote
PR #30 (alert_history retention/resolve) is still open and unrelated: #30