Feat performance

.githooks/_check_tree_isolation.sh

@@ -15,8 +15,8 @@ set -euo pipefail
 
 # Allowlisted lines: file:linenumber pairs that are permitted.
 ALLOWLIST=(
-    "tree/item.py:28"
-    "tree/item.py:29"
+    "tree/item.py:30"
+    "tree/item.py:31"
 )
 
 is_allowlisted() {

agent.md

@@ -0,0 +1,64 @@
+# Agent Guide — Editable-Tree-Model-Example (compact)
+
+_High-signal rules for AI agents. Keep this brief and actionable._
+**Last updated:** 2026-06-13
+
+## 1) First commands (always)
+
+```bash
+. .venv/bin/activate
+timeout 1200 make gate
+```
+
+- Tools live in `.venv`.
+- `make gate` is mandatory before every commit.
+
+## 2) Mandatory delivery loop (do not skip steps)
+
+For plan-based work, execute exactly this loop:
+
+1. **Pick one next unchecked plan item** (single scope).
+2. **Implement only that scope**.
+3. **Run targeted tests** for touched files.
+4. **Run full gate** (`timeout 1200 make gate`).
+5. **Commit immediately** (message references plan item).
+6. **Mark plan checkbox `[x]`** only after commit.
+7. Repeat for the next item.
+
+Hard rules:
+- If tests/gate fail: go back to implementation; **no commit**.
+- Do not batch multiple plan items into one commit unless plan explicitly says so.
+- Do not stop at “green but uncommitted”.
+
+## 3) Critical architecture facts (easy to miss)
+
+1. **Undo edit path bypasses `JsonTreeItem.set_data()`**
+   - Real replay path: `DocumentMutationGateway` → undo command → `undo/diff.py:DiffApplier.apply()`.
+   - Type/value fixes often require changes in both item logic and `DiffApplier`.
+
+2. **`mpq` whole numbers are inferred as FLOAT unless converted**
+   - Convert `mpq(n,1)` to `int` where integer semantics are required.
+
+3. **UI uses proxy model**
+   - Map indices proxy↔source before touching tree items.
+
+## 4) Isolation constraints (must hold)
+
+- `editors/inline/*`, `editors/windowed/*` must not import `app/`, `documents/`, `tree/`.
+- `editors/factory.py`, `editors/context.py` must not import `app/`, `documents/`.
+- `tree/` must not import `app/`, `documents/`, `editors/`, `delegates/`, `state/`, `validation/`.
+- No reflection (`getattr` / `hasattr` / `TYPE_CHECKING`) outside allowlist.
+
+## 5) Minimal file map for common work
+
+- Types/coercion: `tree/types.py`, `tree/item_coercion.py`
+- Item/model behavior: `tree/item.py`, `tree/model.py`
+- Undo replay: `undo/commands.py`, `undo/diff.py`
+- Tab composition/lifecycle: `documents/composition/*`, `app/tab_lifecycle.py`, `app/main_window.py`
+- Validation: `documents/controllers/validation.py`, `validation/*`
+
+## 6) Testing quick rules
+
+- Use `QT_QPA_PLATFORM=offscreen` for pytest.
+- Prefer focused tests during development, then full gate.
+- Add regression tests for every bug fix or plan checkpoint.

ai-memory/repo-map.md

@@ -2,8 +2,8 @@
 
 _This is a condensed index and architectural summary. LLM agents should refer to direct source files for implementation
 details._
-**Last updated:** 2026-06-01 (after tree-upward-imports refactor; added `core/`, `tree/codecs/`,
-tree-isolation rule, and `check-tree-isolation` target).
+**Last updated:** 2026-06-13 (after raw-numeric edit-flow fix; added DiffApplier RAW_FLOAT routing,
+integer promotion for whole-number mpq edits, and `agent.md`).
 
 ## 1) High-level Purpose
 
@@ -25,7 +25,7 @@ Model".
 | **Type System**     | `tree/types.py` (Definitions), `tree/item_coercion.py` (Conversion)                                             |
 | **Editor Widgets**  | `editors/factory.py` (dispatch), `editors/inline/`, `editors/windowed/`                                         |
 | **Delegates**       | `delegates/value.py` (paint + createEditor → editors.factory), `delegates/formatting/`                          |
-| **Undo System**     | `undo/commands.py` (Operations), `undo/diff.py` (Surgical replay)                                               |
+| **Undo System**     | `undo/commands.py` (Operations), `undo/diff.py` (Surgical replay + RAW_FLOAT routing)                            |
 | **Structural Ops**  | `tree_actions/` (Clipboard, DnD, Move, Sort, Anchors)                                                           |
 | **Validation**      | `validation/` (JSON-Schema), `app/validation_presenter.py`                                                      |
 | **Theming**         | `themes/`, `app/theme_controller.py`                                                                            |
@@ -43,6 +43,15 @@ Model".
   how data is handled. Don't scatter type logic in the UI.
 - **Surgical Model Updates**: The `DiffApplier` (`undo/diff.py`) is used during Undo/Redo to emit minimal Qt signals.
   This preserves UI state like selection and expansion that would be lost on a full model reset.
+  **Important**: `DiffApplier.apply()` bypasses `JsonTreeItem.set_data()` — special type handling (e.g., `RAW_FLOAT`
+  routing to `_set_raw_numeric_value`) must be added to `DiffApplier.apply()` explicitly.
+- **Edit flow path**: Editor → `editors/factory.set_value_model_data()` → `DefaultEditContext.commit()` →
+  `DocumentMutationGateway.commit_set_data()` → `CommandDispatcher.push_edit_value()` → `_EditValueCmd` →
+  `DiffApplier.apply()` → `JsonTreeItem._apply_typed_value()` / `_set_raw_numeric_value()`.
+- **Raw numeric values**: Unsupported numeric literals (overflow, underflow, non-finite) are preserved as
+  `RawNumericValue` (`core/raw_numeric.py`) with type `JsonType.RAW_FLOAT`. Edits go through
+  `JsonTreeItem._set_raw_numeric_value()` which handles: safe-parse → int/float conversion, unchanged → preserve,
+  regex-match → keep raw, regex-violate → reject. Whole-number mpq results are promoted to `int` for `INTEGER` type.
 - **No external `data_store.*` reads** (Plan 20). External callers (`app/`, `undo/`, `tree_actions/`, `state/`) must
   reach state through typed `JsonTab.*` properties. The pre-commit hook
   `.githooks/_check_data_store_leaks.sh` enforces this for 17 retired attributes.
@@ -138,6 +147,7 @@ editors/
 │   ├── mpq_spinbox/         QMpqSpinBox (spinbox.py + validator.py).
 │   ├── datetime/            BetterDateTimeEditor + validator (enums/regex imported from core/).
 │   ├── affix_composite.py   AffixCompositeEditor (prefix/suffix + spinbox).
+│   ├── raw_numeric_line.py  RawNumericLineEdit + RawNumericValidator for RAW_FLOAT.
 │   ├── secret_line.py       _SecretLineEdit + _SecretEditorWatcher.
 │   └── caps_safe_line.py    _CapsLockSafeLineEdit + lock-key constants.
 └── windowed/                Modal dialog editors (no app/documents/tree imports).
@@ -153,6 +163,9 @@ editors/
 ```
 core/
 ├── __init__.py
+├── raw_numeric.py           RawNumericValue dataclass + narrow edit regex validator.
+├── safe_mpq.py              Safe mpq parsing (parse_mpq, safe_mpq_from_text, MpqParseResult).
+├── frozen_value.py          Legacy FrozenValue alias → RawNumericValue (compatibility).
 └── datetime_parsing/        Pure datetime parsing (no Qt dependency).
     ├── __init__.py          Re-exports DateTimeCategory, parse_datetime_text, etc.
     ├── enums.py             DateTimeCategory enum.

ai-memory/todo-n-fixme.md

@@ -1,9 +1,8 @@
 # TODO & FIXME
 
-_Last updated: **2026-06-01** (post code-quality audit). Minor smells
-and speculative wishlist entries were pruned; only actionable,
-meaningful work remains. Format:
-`- [ ] [scope] description — file:symbol`._
+_Last updated: **2026-06-13** (post raw-numeric edit-flow fix). Added
+completed entry for DiffApplier RAW_FLOAT routing and integer promotion.
+Format: `- [ ] [scope] description — file:symbol`._
 
 ## High priority — architecture (audit §8)
 
@@ -42,6 +41,11 @@ meaningful work remains. Format:
 
 ## Low priority — hygiene & dead code (audit §6)
 
+- [x] [bug] Fix raw numeric edit flow: `DiffApplier.apply()` now routes
+  `RAW_FLOAT` edits through `_set_raw_numeric_value()` instead of
+  bypassing it; whole-number mpq results are promoted to `int` for
+  `INTEGER` type (displaying "42" not "42.0").
+  — `undo/diff.py:apply`, `tree/item.py:_set_raw_numeric_value`
 - [x] [hygiene] Remove deprecated shims `_closed_tabs_stack` /
   `_MAX_CLOSED_TABS` and the no-op stubs `_setup_validation_dock` /
   `_setup_schemas_menu` — tests and production code now call the

app/loading/__init__.py

@@ -0,0 +1 @@
+"""Loading coordination for file open and reload operations."""