Bugfix/refactoring - #18
Open
Zloydoom4ik wants to merge 9 commits into
Open
Conversation
…f loading it into memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 1 — backend refactoring (layered architecture)
Split the monolithic service.py into layers:
core/config — validated configuration; core/database — single DB engine and get_session.
repositories — database access; services — business logic (FileService, AlertService, StorageService, ProcessingService); exceptions — domain exceptions.
api — routers plus deps plus translation of exceptions into HTTP statuses; app.py became a create_app() factory.
Celery tasks moved onto the shared engine and the service layer.
Removed: the second DB engine, DSN duplication, dead code, duplicated download logic, mkdir side effect on import. Business logic preserved.
Task 2 — non-obvious optimization
File upload switched to streaming to disk (shutil.copyfileobj) instead of reading the whole file into memory, so RAM usage stays constant regardless of file size.
Additional
Fixed the frontend build (the Dockerfile copied a missing .env.production); the API address was moved out of the hardcode into NEXT_PUBLIC_API_URL.
Task 3 (splitting the frontend into layers) was not done.