Refactoring - #15
Open
Roman-Ch-32 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
В целом в проекте были полностью нарушено всё, что можно.
Были перемешаны слои приложения, в частности слои работы с бд, с файлом, были явно перемешаны друг с другом и с АПИ.
Ошибки HTTP вызывались из слоёв сервиса и прочее.
Было проведено разделение на чёткие слои работы приложения, файлы отдельно, бд отдельно,
возможно дальнейшее улучшение.
Переменные вынесены отдельно.
Немного улучшен файл с тасками селери, там тоже были ошибки.
С фронтом я не умею.