Fix TLS Decoder#301
Merged
Merged
Conversation
Owner
spring1843
commented
Jun 7, 2026
- Fix cert decoder to use real decoder rather than mock data
✅ Deploy Preview for freedevtool ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the TLS Decoder tool’s mock certificate parsing with real X.509 parsing via @peculiar/x509, updates the bundled default certificate example, and adjusts E2E assertions to account for CodeMirror rendering only visible lines.
Changes:
- Implement real certificate parsing, extension rendering, fingerprints, and SAN listing in the TLS Decoder UI.
- Replace the TLS decoder default certificate with a real-world example PEM.
- Update TLS Decoder E2E tests to validate only the visible (initial) portion of the default certificate.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/pages/tools/tls-decoder.tsx | Switches from mock parsing to real X.509 decoding and renders detailed extension/fingerprint/SAN info. |
| client/src/data/defaults.ts | Updates the default TLS decoder PEM example. |
| tests/e2e/tools/tls-decoder.spec.ts | Adjusts default-input checks to match CodeMirror’s visible-line rendering behavior. |
| package.json | Adds @peculiar/x509 and reflect-metadata dependencies needed for real parsing. |
| package-lock.json | Locks new dependency tree for X.509 parsing support. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.