Fix group precedence in TypesenseFilterExpressionConverter - #6741
Open
0xmisha wants to merge 1 commit into
Open
Conversation
Signed-off-by: Fedotov Mikhail <mixxxaile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
doGroupoverride inTypesenseFilterExpressionConverterconverts a parenthesized filter group intocontent && content, duplicating the group body and dropping the parentheses that express grouping.Because Typesense evaluates
&&and||with equal precedence from left to right, a filter such asis currently emitted as
This allows documents with country == "BG" to match regardless of the city condition.
Replace the doGroup override with the conventional doStartGroup and doEndGroup hooks that wrap the group content in parentheses.
Testing
Added testGroupAsRightOperand covering a grouped OR expression used as the right-hand operand of an AND.
The expected filter preserves the original grouping: