Skip to content

Make AnthropicChatModel internal methods private #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arimu1 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Make AnthropicChatModel internal methods private #6718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...pring-ai-anthropic/src/main/java/org/springframework/ai/anthropic/AnthropicChatModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ public Flux<ChatResponse> stream(Prompt prompt) {
* chunks and the final response with tool call information or the model's final
* answer.
*/
public Flux<ChatResponse> internalStream(Prompt prompt, @Nullable ChatResponse previousChatResponse) {
private Flux<ChatResponse> internalStream(Prompt prompt, @Nullable ChatResponse previousChatResponse) {

@kuntal1461 kuntal1461 Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. The only caller is stream() on line 283, and since the class is final there's no subclass path either — matches what Ollama, Mistral, DeepSeek, and the rest all do.

Nit (pre-existing, not a blocker): the Javadoc still says "called recursively to support multi-turn tool calling" — that's been stale since a48dc60af moved the recursive loop into ToolCallingManager. Worth a follow-up cleanup but doesn't need to hold up this PR.

return Flux.deferContextual(contextView -> {
MessageCreateParams request = createRequest(prompt, true);
Expand Down Expand Up @@ -541,7 +541,7 @@ else if (streamingState.isTrackingThinking()) {
* turn.
* @return The final {@link ChatResponse} after all tool calls (if any) are resolved.
*/
public ChatResponse internalCall(Prompt prompt, @Nullable ChatResponse previousChatResponse) {
private ChatResponse internalCall(Prompt prompt, @Nullable ChatResponse previousChatResponse) {

@kuntal1461 kuntal1461 Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same story — only call() on line 262 uses this. Good to have both locked down.

Nit: same stale "called recursively" Javadoc as above.

MessageCreateParams request = createRequest(prompt, false);

Expand Down
Loading