Parse long literals in FilterExpressionTextParser - #6701
Open
wxggzz wants to merge 1 commit into
Open
Conversation
Numeric literals without an `L` suffix were always parsed as `Integer`, so filter expressions with values outside the int range (for example a `long` metadata id) failed with a `NumberFormatException`. Fall back to `Long` when the literal exceeds the int range, keeping the existing `Integer` result for smaller values. Fixes spring-projects#4705 Signed-off-by: wxggzz <weixiegen0506@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FilterExpressionTextParserparsed every bare integer literal asInteger, so a filter expression whose value exceeds the int range — e.g. alongmetadata id used when deleting by id — failed with:Fix
visitIntegerConstantnow falls back toLongwhen the literal doesn't fit in anint, while still returningIntegerfor smaller values (backward compatible). Literals with an explicitLsuffix keep going through the existingvisitLongConstantpath, and values insideIN/NINarrays are covered too since they delegate to the same visitor.Tests
Added
testLongValueLiteralcoveringLong.MAX_VALUE/Long.MIN_VALUEand asserting that in-range values still parse asInteger. All 16 parser tests pass locally:Fixes #4705