Optimize Typesense vector query construction - #6151
Closed
chabinhwang wants to merge 1 commit into
Closed
Conversation
Build the vector query directly from the embedding array so search behavior stays identical without boxing floats into a temporary list. Constraint: Spring AI pull requests require DCO sign-off and focused reviewable changes Rejected: Changing Typesense query semantics | performance-only PR should preserve the request format Confidence: high Scope-risk: narrow Directive: Keep vector query formatting compatible with existing Typesense requests Tested: ./mvnw -pl vector-stores/spring-ai-typesense-store -Dtest=TypesenseVectorStoreTests test; ./mvnw -pl vector-stores/spring-ai-typesense-store package; git diff --check Not-tested: Full repository ./mvnw package Signed-off-by: chabinhwang <7chabin@gmail.com>
Contributor
Author
|
Superseded by #6707, which is rebased on current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
float[]instead of creating a boxedStream<Float>and intermediateListbeforeString.join.Why
This preserves the existing Typesense vector query string format while reducing temporary allocations during similarity search request construction.
Validation
./mvnw -pl vector-stores/spring-ai-typesense-store -Dtest=TypesenseVectorStoreTests test./mvnw -pl vector-stores/spring-ai-typesense-store packagegit diff --checkNotes
No associated issue; this is a small internal allocation optimization with behavior-preserving tests.