fix(filecheck): skip existence check and UI badge when mode is none#865
Open
SnitchTeam wants to merge 1 commit intospotbye:mainfrom
Open
fix(filecheck): skip existence check and UI badge when mode is none#865SnitchTeam wants to merge 1 commit intospotbye:mainfrom
SnitchTeam wants to merge 1 commit intospotbye:mainfrom
Conversation
- Early return CheckFilesExistence with Exists=false when existingFileCheckMode is 'none' - Skip Wails CheckFilesExistence calls in useDownload.ts when mode is 'none' - Extend ExistingFileCheckMode type and normalizeExistingFileCheckMode to include 'none'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #848 (disable filecheck).
When
existingFileCheckModeis set to"none", the backend still performed the full existence lookup and returnedExists: true, causing the "already exists" yellow badge to remain in the UI even though the download proceeded normally.Changes:
app.go): early returnExists: falsefor all tracks when mode is"none"useDownload.ts): skip the 3CheckFilesExistenceWails calls when mode is"none"settings.ts): extendExistingFileCheckModetype andnormalizeExistingFileCheckModeto include"none"Build and vet pass.