Upgrade: SDK-Migration#37
Closed
abhgoel15 wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub App — Migration to splunk-soar-sdk
Features
BaseConnectorSDK to the newsplunk-soar-sdkframeworkgithub_connector.pyusing the newApp,Params,ActionOutput, andSOARClientpatternsadd collaborator,remove collaborator,add member,remove member,list teams,list repos,list organizations,list issues,list events,create issue,update issue,create comment,add labelsBaseAssetwithAssetField(PAT, username/password, OAuth client ID/secret)Bug Fixes
Manual Documentation
Other information
This PR completes the rewrite of the GitHub connector against the new
splunk-soar-sdk. The legacy connector (github_connector.py) served as the reference implementation for all business logic, pagination behavior, API endpoint selection, and error handling. The new app preserves full functional parity while adopting the SDK's declarative action/output schema, Pydantic-based parameter validation, and Jinja2 template rendering for action views.