Support tricount imports#526
Open
Mubelotix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I have been hosting my own instance of Spliit for a long time and really appreciate the project. As I see that there is currently a high level of activity that can be a lot to handle for you, I wanted to offer my help. I would be more than happy to commit as a new maintainer to help with handling issues, reviewing MRs, and driving new updates to keep the project moving forward!
To start off, this MR implements a much-requested feature: importing groups and expenses. I implemented it for Tricount but it could be reused for splitwise.
What this MR does:
Adds a clean, interactive import section to the Group Creation page with step-by-step instructions guiding the user on how to obtain their data export under GDPR terms from Tricount.
It allows the user to select the group's main currency during the import. All imported expenses are converted to this currency using the rates in the CSV file (falling back to Frankfurter API if a rate is missing).
It also fixes an existing bug where the database field originalAmount was stored in minor units (cents) but was not converted to/from decimals in the frontend form ( submit and defaultValues ), causing 100x scaling display issues.