fix: encode empty WebStorage tags as JSON object for Buggregator#7
Open
SavKS wants to merge 1 commit into
Open
fix: encode empty WebStorage tags as JSON object for Buggregator#7SavKS wants to merge 1 commit into
SavKS wants to merge 1 commit into
Conversation
Buggregator rejects profiles when tags is [] because it expects a map.
Send {} for empty tags so Laravel/xhprof integrations can store profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebStoragesent emptytagsas JSON[]. Buggregator returns400(cannot unmarshal array into ... tags of type map[string]interface{}), so profiles from Laravel (maantje/xhprof-buggregator-laravel) never appeared.{}(stdClass/ empty object) instead of[].WebStorageTestasserts empty tags encode as"tags":{}and non-empty tags are unchanged.Test plan
vendor/bin/phpunitcurlwithtags:[]→ 400,tags:{}→ 200 against Buggregator