fix: cap the bar sparkline one grade short of full height - #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap the bar-format sparkline one grade short of full height so maxed rows stay visually separated.
Summary
▁–▇), so a value at 100% renders as▇and never the full block█.remote metrics --format=bar,fleet metrics --format=bar, and the dashboard tiles. Thegaugeformat is unchanged.Implementation details
Reducing
barGlyphsto the seven sub-full blocks makes the cap structural — the set simply contains no█, rather than clamping the index. This re-buckets the mid range to even ~14% bands; the shift is invisible because the trailing percentage is the precise reading.