Update Readme - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates script references and contract configurations to support a new EUR_UKTBL token variant alongside existing token types. The changes streamline library generation while adding comprehensive setup for the new token.
- Addition of EUR_UKTBL token support to deployment and setup scripts
- Removal of unused token library generation functions and calls
- Fix for missing environment parameters in library generation script call
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/setup_contracts.sh | Adds EUR_UKTBL token setup including address extraction and contract configuration functions |
| scripts/generate_contract_libraries.sh | Removes unused library generation functions for multiple token types |
| scripts/bootstrap.sh | Fixes missing environment parameters when calling generate_contract_libraries.sh |
| contracts/redemption/test_snapshots/*.json | Updates test snapshots with new contract hash and metadata changes |
Comments suppressed due to low confidence (1)
scripts/generate_contract_libraries.sh:1
- The echo statements indicate library generation, but the actual function calls are for adding tokens to redemption (add_ustbl_to_redemption, add_uktbl_to_redemption) rather than library generation functions. This appears to be a copy-paste error where the wrong functions are being called.
#!/bin/bash
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.