Skip to content

Last pr before audit - #15

Merged
nicolasassouad merged 2 commits into
mainfrom
last-pr-before-audit
Aug 26, 2025
Merged

Last pr before audit#15
nicolasassouad merged 2 commits into
mainfrom
last-pr-before-audit

Conversation

@nicolasassouad

Copy link
Copy Markdown
Contributor

No description provided.

@nicolasassouad nicolasassouad self-assigned this Aug 26, 2025
Copilot AI review requested due to automatic review settings August 26, 2025 05:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be a final cleanup before an audit, making consistency improvements to contract variable naming, role assignments, and idempotency key storage durability.

  • Updates token naming to use consistent underscore separators
  • Fixes role assignments from redemption to burner and redemption executor to relayer
  • Changes idempotency key storage from persistent to temporary durability
  • Adds deployment and bootstrap scripts for automated contract management

Reviewed Changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
scripts/setup_contracts.sh Updates token key names and reassigns roles between redemption and relayer contracts
scripts/generate_contract_libraries.sh Updates token key names to match setup script
scripts/deploy_contracts.sh Adds new deployment script for automated contract deployment
scripts/bootstrap.sh Adds bootstrap script to streamline the full deployment process
test snapshot files Updates test snapshots to reflect changes in idempotency storage and function naming

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/deploy_contracts.sh
Comment thread scripts/bootstrap.sh
Comment thread scripts/deploy_contracts.sh
Comment thread scripts/deploy_contracts.sh
@nicolasassouad
nicolasassouad merged commit 6a2a2a9 into main Aug 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants