Last pr before audit - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be a final cleanup before an audit, making consistency improvements to contract variable naming, role assignments, and idempotency key storage durability.
- Updates token naming to use consistent underscore separators
- Fixes role assignments from redemption to burner and redemption executor to relayer
- Changes idempotency key storage from persistent to temporary durability
- Adds deployment and bootstrap scripts for automated contract management
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/setup_contracts.sh | Updates token key names and reassigns roles between redemption and relayer contracts |
| scripts/generate_contract_libraries.sh | Updates token key names to match setup script |
| scripts/deploy_contracts.sh | Adds new deployment script for automated contract deployment |
| scripts/bootstrap.sh | Adds bootstrap script to streamline the full deployment process |
| test snapshot files | Updates test snapshots to reflect changes in idempotency storage and function naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.