This repository was archived by the owner on Feb 17, 2026. It is now read-only.
Specify catalog query execution#31
Merged
Merged
Conversation
…ryder-gillen-ltk/go-athena into specify-catalog-query-execution
- Resolve catalog from context in startQuery() to honor SetCatalog() overrides - Use nil instead of empty string for Catalog in QueryExecutionContext to avoid API errors when catalog is not explicitly set - Fall back to default "AwsDataCatalog" in GetTableMetadata where CatalogName is a required parameter Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix catalog handling in Athena query execution to properly support context overrides and prevent API errors with empty
catalog values.
Why
The previous change (#29 fork) added
CatalogtoQueryExecutionContextbut had two issues:Open(Config{})users: WhenCatalogis not explicitly set,aws.String("")sends an emptystring to the Athena API, causing
InvalidRequestException. Previously, the field was omitted and Athena used itsdefault catalog.
SetCatalog()context override ignored:startQuery()always usedc.catalogfrom the connection struct,ignoring per-query catalog overrides set via
SetCatalog(ctx, ...). This made the context-based catalog overridenon-functional for actual query execution.
Additionally,
GetTableMetadatain GzipDL mode had the same empty string issue withCatalogName, which is a requiredparameter.
How
startQuery(): resolve catalog from context viagetCatalog(ctx)with fallback toc.catalog, and usenilinstead of
aws.String("")when catalog is empty so Athena uses its default.getTableAsync(): fall back to"AwsDataCatalog"(the default catalog constant) when catalog is empty, sinceCatalogNameis a required parameter forGetTableMetadata.Ref