fix: route /shared/skills through custom domain ingress - #5088
Open
simplesagar wants to merge 1 commit into
Open
fix: route /shared/skills through custom domain ingress#5088simplesagar wants to merge 1 commit into
simplesagar wants to merge 1 commit into
Conversation
The skill share page shipped in #5023 mounted the app route, but the custom-domain Kubernetes Ingress only forwards an allowlist of paths (/mcp, /oauth, specific /.well-known entries) to the Gram server, so /shared/skills/{token} died at nginx with a bare 404. Add the path to the ingress spec; existing domains pick it up on their next re-apply. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJMDX91x4yiwU5PWyv6m6p
🦋 Changeset detectedLatest commit: bfb78ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
adaam2
approved these changes
Aug 9, 2026
danielkov
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for #5023: shared skill pages on custom domains returned a bare nginx 404 (e.g.
https://chat.speakeasy.com/shared/skills/<token>).Root cause: the app route existed, but the custom-domain Kubernetes Ingress (
server/internal/k8s/ingress_provisioner.go) only forwards an allowlist of paths to the Gram server —/mcp,/oauth, and specific/.well-known/*entries./shared/skills/*was never routed, so requests died at the edge before reaching the handler.Fix: add
/shared/skills(PathType Prefix, same backend service) to the main custom-domain ingress spec, mirroring/mcp.Rollout note
Existing domains keep their old Ingress object until the next re-apply — there is no reconcile-all on deploy. After this deploys, trigger a re-apply per affected domain via the domain edit flow (saving domain settings runs
CustomDomainUpdateWorkflow→ReconcileCustomDomain→provisioner.Applywith the new spec).Testing
ingress_provisioner_test.go;go test ./server/internal/k8s/passes.mise lint:serverclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01SJMDX91x4yiwU5PWyv6m6p
Summary by cubic
Route
/shared/skillsthrough the custom-domain Kubernetes Ingress so public skill share pages work on custom domains instead of returning an NGINX 404.Bug Fixes
/shared/skills(PathType Prefix) to the custom-domain ingress to forward to the Gram server.server/internal/k8s/ingress_provisioner_test.go.Migration
CustomDomainUpdateWorkflow→ReconcileCustomDomain.Written for commit bfb78ab. Summary will update on new commits.