Feat: Updates LayerCard Component to be Controlled By Parent Components#107
Merged
Conversation
…nt but also hoist control of the info button to the parent component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the logic for the LayerCard component to no longer accept specific props which were effectively rendered as children but controlled by the component itself. Instead the component will simply render any children it is passed but will also now accept a
onShowInfoprop for a function handler for clicking on the info button. This allows the parent components to control the rendering of specific children and removes the "opinionation" of the LayerCard component.Type of change
Delete options that are not relevant.
Instructions
View the LayerCard component in storybook
How Has This Been Tested?
Describe the tests that you ran to verify the changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: