Skip to content

py-plaid: new package - #4925

Merged
RikkiButler20 merged 9 commits into
spack:developfrom
williampiat3:Plaid
Jun 9, 2026
Merged

py-plaid: new package#4925
RikkiButler20 merged 9 commits into
spack:developfrom
williampiat3:Plaid

Conversation

@williampiat3

@williampiat3 williampiat3 commented May 21, 2026

Copy link
Copy Markdown
Contributor

This PR depends on PR #4888, waiting for it to be merged

@spackbot-triage spackbot-triage Bot added new-package Additions of new packages to the Spack ecosystem new-version Modifications to packages' `depends_on()` directives python dependencies Modifications with a `depends_on()` directive labels May 21, 2026
@williampiat3
williampiat3 marked this pull request as draft May 21, 2026 14:00
@williampiat3

Copy link
Copy Markdown
Contributor Author

@spackbot fix style

@spackbot-app

spackbot-app Bot commented May 21, 2026

Copy link
Copy Markdown

Let me see if I can fix that for you!

@spackbot-app

spackbot-app Bot commented May 21, 2026

Copy link
Copy Markdown

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/py_plaid/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (106 > 99)�[0m
  �[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_plaid/package.py:11:100
   �[1m�[94m|�[0m
�[1m�[94m10 |�[0m class PyPlaid(PythonPackage):
�[1m�[94m11 |�[0m     """A package that implements a data model tailored for AI and ML in the context of physics problems"""
   �[1m�[94m|�[0m                                                                                                    �[1m�[91m^^^^^^^�[0m
�[1m�[94m12 |�[0m
�[1m�[94m13 |�[0m     homepage = "https://github.com/PLAID-lib/plaid"
   �[1m�[94m|�[0m

Found 2 errors (1 fixed, 1 remaining).
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@williampiat3
williampiat3 marked this pull request as ready for review May 21, 2026 14:57
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
Comment thread repos/spack_repo/builtin/packages/py_plaid/package.py Outdated
@RikkiButler20 RikkiButler20 self-assigned this May 22, 2026
@RikkiButler20 RikkiButler20 changed the title New recipe: py-plaid py-plaid: add package May 22, 2026
@RikkiButler20

Copy link
Copy Markdown
Contributor

Were you able to successfully build py-plaid?

williampiat3 and others added 5 commits May 22, 2026 09:09
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
@williampiat3

Copy link
Copy Markdown
Contributor Author

Were you able to successfully build py-plaid?

Yes the recipe worked for me on linux, did not test on windows

@alecbcs alecbcs changed the title py-plaid: add package py-plaid: new package Jun 2, 2026

@RikkiButler20 RikkiButler20 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

@RikkiButler20
RikkiButler20 enabled auto-merge (squash) June 9, 2026 21:53
@RikkiButler20
RikkiButler20 merged commit 8168ab3 into spack:develop Jun 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Modifications with a `depends_on()` directive new-package Additions of new packages to the Spack ecosystem new-version Modifications to packages' `depends_on()` directives python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants