py-plaid: new package - #4925
Merged
Merged
Conversation
williampiat3
marked this pull request as draft
May 21, 2026 14:00
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/py_plaid/package.py
�[1;34m==> �[0mrunning ruff format
1 file left unchanged
�[1;34m==> �[0mrunning ruff check
�[1m�[91mE501 �[0m�[1mLine too long (106 > 99)�[0m
�[1m�[94m-->�[0m repos/spack_repo/builtin/packages/py_plaid/package.py:11:100
�[1m�[94m|�[0m
�[1m�[94m10 |�[0m class PyPlaid(PythonPackage):
�[1m�[94m11 |�[0m """A package that implements a data model tailored for AI and ML in the context of physics problems"""
�[1m�[94m|�[0m �[1m�[91m^^^^^^^�[0m
�[1m�[94m12 |�[0m
�[1m�[94m13 |�[0m homepage = "https://github.com/PLAID-lib/plaid"
�[1m�[94m|�[0m
Found 2 errors (1 fixed, 1 remaining).
I've updated the branch with style fixes. |
williampiat3
marked this pull request as ready for review
May 21, 2026 14:57
RikkiButler20
requested changes
May 22, 2026
Contributor
|
Were you able to successfully build |
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Co-authored-by: Richarda Butler <39577672+RikkiButler20@users.noreply.github.com>
Contributor
Author
Yes the recipe worked for me on linux, did not test on windows |
RikkiButler20
approved these changes
Jun 9, 2026
RikkiButler20
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay.
RikkiButler20
enabled auto-merge (squash)
June 9, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #4888, waiting for it to be merged