Fix "spawn tiles" window UIBox2 errors - #6932
Open
eoineoineoin wants to merge 2 commits into
Open
Conversation
Contributor
|
it should show the id on hover like entity spawn menu at least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like space-wizards/space-station-14#45085, but now for engine!
If you open the sandbox menu and hit the "spawn tiles" button, you'll see UIBox2 failing validation. Some of the tile textures had multiple variants, and the ItemList had not enough room for displaying text. 8969a8f just added a sanity Math.Min to make that piece robust.
The tile menu displays all the variants of the tile, which, IMO looks bad:
The ItemList supports showing only a subset of a texture, but this feature was unused and didn't work. afea191 fixes that and displays only the first tile variant in that UI:
A few tile types have the same name and same variant0 (see the "asteroid sand" in that screenshot), so probably need to do something there? Animate switching between the variants? Just give them different names? An explicit icon in the tile prototype? Open to suggestions.