Hotfix: pass last state in SharedUserInterfaceSystem.EnsureClientBui - #6840
Merged
Princess-Cheeseballs merged 3 commits intoJul 24, 2026
Conversation
Princess-Cheeseballs
requested changes
Jul 24, 2026
Comment on lines
+557
to
+558
| AddQueued(boundUserInterface, QueuedUpdate.Open); | ||
| var state = entity.Comp.States.GetValueOrDefault(key); | ||
| AddQueued(boundUserInterface, QueuedUpdate.Open, state); |
Member
There was a problem hiding this comment.
Might want an API like "AddQueuedState" that does the boilerplate automatically and use that in both places where we do this.
Contributor
Author
There was a problem hiding this comment.
Changes should be applied, and I commented the two AddQueued... methods.
[Tested again, still functional.]
Member
|
I'll test and merge after I'm done doing staging stuff |
Princess-Cheeseballs
approved these changes
Jul 24, 2026
Princess-Cheeseballs
left a comment
Princess-Cheeseballs
left a comment
Member
There was a problem hiding this comment.
Yummy! More tags released!
pull Bot
pushed a commit
to weaversam8/RobustToolbox
that referenced
this pull request
Aug 4, 2026
…ards#6840) (space-wizards#6900) * Revert "Hotfix: pass last state in SharedUserInterfaceSystem.EnsureClientBui (space-wizards#6840)" This reverts commit 08b3257. * Revert "Bugfix: SharedUserInterfaceSystem stores and applies BUI states in order. (space-wizards#6829)" This reverts commit c766e79. * Revert "Defer UI operations until UI system runs frame update (space-wizards#6789)" This reverts commit f44d7e0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues described in #6829 (comment)
I goofed. This sends null state when the last available state might not be null!
Proof of the pudding on ss14 master + a few compilation fixes for v284.
just-devouring-rocks.mp4
@deltanedas sorry about that - see video attached, test for yourself