Безопасное время для SCP457 - #1114
Merged
WardexOfficial merged 2 commits intoAug 5, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughДля SCP-457 добавлена настройка ChangesSafeTime для SCP-457
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Server/_Scp/Scp457/Scp457System.cs`:
- Around line 231-232: Update the SafeTime check in Scp457System to call
IsInSafeTime with silent set to true using named arguments, while preserving the
existing early return when the entity is in safe time.
- Around line 231-232: В методе TryChangeSize ограничьте проверку SafeTime
условием delta < 0f, чтобы она блокировала только уменьшение размера;
положительный delta должен продолжать изменять размер, включая вызовы из
TryConsume.
- Line 48: Rename the private field DecayInterval to _decayInterval and update
all references, including the usages around lines 76 and 85. Since the interval
is never modified, declare it static readonly while preserving its current value
and behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2b75d5d5-9837-4bd5-bb58-d40753a1cbd3
📒 Files selected for processing (2)
Content.Server/_Scp/Scp457/Scp457System.csResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp457.yml
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Shared/_Scp/SafeTime/SafeTimeComponent.cs`:
- Around line 19-23: Update the XML documentation on
SafeTimeComponent.TimeFromRoundStart so the <summary> is written in English and
follows standard C# XML-doc style. Replace the current Russian text and typo
with a concise English description of what the field controls, keeping the
[DataField] member unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4b75bd53-56ca-48cd-bc25-93a98b4e7302
📒 Files selected for processing (5)
Content.Server/_Scp/Scp457/Scp457System.csContent.Shared/_Scp/SafeTime/SafeTimeComponent.csContent.Shared/_Scp/SafeTime/SafeTimeSystem.csResources/Prototypes/_Scp/Actions/scp457.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp457.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Краткое описание
Безопасное время для SCP457
Changelog
🆑 Wardex
Summary by CodeRabbit