feature(otel-collector): ordered processors list#910
Open
filiphaftek wants to merge 1 commit into
Open
Conversation
filiphaftek
changed the title
michaellzc
approved these changes
Jul 16, 2026
bobheadxi
reviewed
Jul 16, 2026
Comment on lines
+47
to
+55
| {{- if .Values.openTelemetry.gateway.config.traces.processorOrderedList }} | ||
| {{- range .Values.openTelemetry.gateway.config.traces.processorOrderedList }} | ||
| - {{ . }} | ||
| {{- end }} | ||
| {{- else }} | ||
| {{- range $key, $val := .Values.openTelemetry.gateway.config.traces.processors }} | ||
| - {{ $key }} | ||
| {{- end }} | ||
| {{- end }} |
Member
There was a problem hiding this comment.
Should processors and processorOrderedList be mutually exclusive? Curious why we shouldn't deprecate processors or simply change its shape as processors is effectively buggy it seems
bobheadxi
reviewed
Jul 16, 2026
Comment on lines
45
to
+47
| {{- if .Values.openTelemetry.gateway.config.traces.processors }} | ||
| processors: | ||
| {{- if .Values.openTelemetry.gateway.config.traces.processorOrderedList }} |
Member
There was a problem hiding this comment.
doesn't this mean without processors, processorOrderedList does not work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otel-collector processors list is using map keys, which is sorted alphabethically.
Some processoers should be used in order i.e. tail_sampling before batch, so this PR adds additional property to set proper order of the processors. It can only be used together with processors definition.
Change is backward compatible
Checklist
Test plan
Unit tests.
e2e