Disable tests for compiler hangs#609
Closed
sourcefrog wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables two integration tests in tests/main.rs that can leave hung rustc processes when the project is run under cargo mutants, addressing issue #521.
Changes:
- Disabled the
mutants_causing_tests_to_hang_are_stopped_by_manual_timeoutintegration test by commenting it out. - Disabled the
constfn_mutation_passes_checkintegration test by commenting it out.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sourcefrog
force-pushed
the
521-hang-when-mutated
branch
from
540a67e to
c35c1e2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sourcefrog
force-pushed
the
521-hang-when-mutated
branch
from
c35c1e2 to
247c72e
Compare
When these are run under cargo mutants, they tend to leave hung processes running, and I don't think we strictly need them. Fixes #521
Owner
Author
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these are run under cargo mutants, they tend to leave hung processes running, and I don't think we strictly need them.
Fixes #521