CSE Machine : Stepper full screen NOT working FIX#3900
Open
Akshay-2007-1 wants to merge 4 commits into
Open
Conversation
github-project-automation
Bot
moved this to Todo
in SA 2627 CP3108 P05: CSE Machine liveness
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Contributor
Author
|
@coderabbitai review |
Akshay-2007-1
moved this from Todo
to In Progress
in SA 2627 CP3108 P05: CSE Machine liveness
Contributor
✅ Actions performedReview triggered.
|
Contributor
WalkthroughSideContentCseMachineBase adds a ChangesSlider Remounting Fix for Fullscreen CSE Machine
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/commons/sideContent/content/SideContentCseMachine.tsx`:
- Around line 188-196: The nested requestAnimationFrame in
handleFullscreenChange (and the other similar double-rAF call sites that set
sliderKey) can fire after unmount and call setState; fix by adding a helper
(e.g., scheduleDoubleRaf or scheduleRaf) that calls requestAnimationFrame twice,
stores the returned rAF ids in an array on the instance, and returns a cancel
token; call this helper from handleFullscreenChange and the other call site(s)
instead of raw rAFs, implement componentWillUnmount to iterate stored ids and
cancelAnimationFrame for each (and clear the array), and ensure any canceled
scheduled callbacks do not call setState after unmount.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c88eaa04-6a53-464f-ae51-575d4743d4d3
📒 Files selected for processing (1)
src/commons/sideContent/content/SideContentCseMachine.tsx
Comment on lines
+188
to
+196
| private handleFullscreenChange = () => { | ||
| // Double rAF ensures the browser has completed layout after the fullscreen | ||
| // transition before Blueprint Slider remounts and measures its track width. | ||
| requestAnimationFrame(() => { | ||
| requestAnimationFrame(() => { | ||
| this.setState(prev => ({ sliderKey: prev.sliderKey + 1 })); | ||
| }); | ||
| }); | ||
| }; |
Contributor
There was a problem hiding this comment.
Cancel queued remount callbacks on unmount.
The nested requestAnimationFrame callbacks can still run after unmount and call setState. Track rAF ids and cancel them in componentWillUnmount (and reuse one helper for both call sites).
Proposed fix
class SideContentCseMachineBase extends Component<CseMachineProps, State> {
+ private sliderRemountRaf1: number | null = null;
+ private sliderRemountRaf2: number | null = null;
+
+ private scheduleSliderRemount = () => {
+ this.sliderRemountRaf1 = requestAnimationFrame(() => {
+ this.sliderRemountRaf2 = requestAnimationFrame(() => {
+ this.setState(prev => ({ sliderKey: prev.sliderKey + 1 }));
+ });
+ });
+ };
private handleFullscreenChange = () => {
- // Double rAF ensures the browser has completed layout after the fullscreen
- // transition before Blueprint Slider remounts and measures its track width.
- requestAnimationFrame(() => {
- requestAnimationFrame(() => {
- this.setState(prev => ({ sliderKey: prev.sliderKey + 1 }));
- });
- });
+ // Double rAF ensures layout settles before Slider remount/re-measure.
+ this.scheduleSliderRemount();
};
componentWillUnmount() {
this.handleResize.cancel();
window.removeEventListener('resize', this.handleResize);
document.removeEventListener('fullscreenchange', this.handleFullscreenChange);
+ if (this.sliderRemountRaf1 !== null) cancelAnimationFrame(this.sliderRemountRaf1);
+ if (this.sliderRemountRaf2 !== null) cancelAnimationFrame(this.sliderRemountRaf2);
if (!this.isJava()) {
CseMachine.resetArrowOriginFilters();
}
}
componentDidUpdate(prevProps: {
@@
- requestAnimationFrame(() => {
- requestAnimationFrame(() => {
- this.setState(prev => ({ sliderKey: prev.sliderKey + 1 }));
- });
- });
+ this.scheduleSliderRemount();
}
}Also applies to: 205-209, 236-242
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/commons/sideContent/content/SideContentCseMachine.tsx` around lines 188 -
196, The nested requestAnimationFrame in handleFullscreenChange (and the other
similar double-rAF call sites that set sliderKey) can fire after unmount and
call setState; fix by adding a helper (e.g., scheduleDoubleRaf or scheduleRaf)
that calls requestAnimationFrame twice, stores the returned rAF ids in an array
on the instance, and returns a cancel token; call this helper from
handleFullscreenChange and the other call site(s) instead of raw rAFs, implement
componentWillUnmount to iterate stored ids and cancelAnimationFrame for each
(and clear the array), and ensure any canceled scheduled callbacks do not call
setState after unmount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3820. The stepper now works as intended!
Type of change
How to test
Test using the given code at #3820.
Checklist