Skip to content

ci: consolidate test and coverage jobs - #34

Merged
soulteary merged 1 commit into
mainfrom
ci/consolidate-test-workflows
Aug 26, 2026
Merged

ci: consolidate test and coverage jobs#34
soulteary merged 1 commit into
mainfrom
ci/consolidate-test-workflows

Conversation

@soulteary

Copy link
Copy Markdown
Owner

Summary

  • upload Codecov results from the existing race-enabled Quality test instead of running a second full test job
  • remove the redundant coverage workflow
  • stop running the Release workflow on every main push while preserving tag and manual triggers
  • rely on setup-go's module cache instead of a second cache action in Release

Verification

  • parsed all remaining workflow files as YAML
  • go test ./...
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5e38c3a73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +58 to +60
- name: Upload coverage to Codecov
continue-on-error: true
uses: codecov/codecov-action@04b047e8bb82a0c002c8312c1c880fbc6a999d45 # v5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Upload coverage before unrelated checks

When go vet, the govulncheck installation, or the vulnerability scan fails after tests successfully produce coverage.out, GitHub's implicit success() condition skips this upload. The deleted Codecov workflow uploaded whenever its tests succeeded, so this consolidation now leaves Codecov stale during unrelated check failures; move the upload directly after the test or otherwise condition it on the coverage-producing step.

Useful? React with 👍 / 👎.

@soulteary
soulteary force-pushed the ci/consolidate-test-workflows branch from d5e38c3 to 1f4e973 Compare August 26, 2026 16:11
@soulteary
soulteary merged commit c98c329 into main Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant