ci: consolidate test and coverage jobs - #34
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5e38c3a73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Upload coverage to Codecov | ||
| continue-on-error: true | ||
| uses: codecov/codecov-action@04b047e8bb82a0c002c8312c1c880fbc6a999d45 # v5 |
There was a problem hiding this comment.
Upload coverage before unrelated checks
When go vet, the govulncheck installation, or the vulnerability scan fails after tests successfully produce coverage.out, GitHub's implicit success() condition skips this upload. The deleted Codecov workflow uploaded whenever its tests succeeded, so this consolidation now leaves Codecov stale during unrelated check failures; move the upload directly after the test or otherwise condition it on the coverage-producing step.
Useful? React with 👍 / 👎.
d5e38c3 to
1f4e973
Compare
Summary
mainpush while preserving tag and manual triggerssetup-go's module cache instead of a second cache action in ReleaseVerification
go test ./...git diff --check