Skip to content

CI 품질 게이트 실패 원인 수정#44

Merged
sorlros merged 1 commit into
releasefrom
stabilize/release-p0-health-hardening
Jun 2, 2026
Merged

CI 품질 게이트 실패 원인 수정#44
sorlros merged 1 commit into
releasefrom
stabilize/release-p0-health-hardening

Conversation

@sorlros

@sorlros sorlros commented Jun 2, 2026

Copy link
Copy Markdown
Owner

변경 사항

  • Backend 테스트가 외부 Supabase 환경변수 없이 실행되도록 서비스 초기화를 lazy 구조로 변경했습니다.
  • ImageService, RagService, ChatService의 Supabase/RAG 의존성을 실제 사용 시점에만 초기화하도록 수정했습니
    다.
  • 중복 client_request_id 스트리밍 응답 재사용 시 ChatService를 생성하지 않도록 수정했습니다.
  • Flutter analyze 실패 원인이던 cacheExtent deprecation을 호환 방식으로 처리했습니다.
  • lazy initialization 회귀 테스트를 추가했습니다.

검증

  • Backend tests: success
  • Frontend tests: success
  • GitHub Actions CI: success

CI run:
https://github.com/sorlros/NovelAIne/actions/runs/26802127435

후속 확인

  • PR merge 후 release 브랜치의 Deploy Frontend to Vercel workflow 통과 여부 확인
  • Render backend 배포 브랜치가 release 기준인지 유지 확인

@vercel

vercel Bot commented Jun 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
novelaine Ready Ready Preview, Comment Jun 2, 2026 6:23am

@sorlros
sorlros merged commit e89c618 into release Jun 2, 2026
6 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements lazy initialization for several backend services and clients (including ChatService, ImageService, RagService, and the Supabase client) to optimize resource usage and prevent unnecessary instantiation, supported by new unit tests. In the frontend, an unnecessary // ignore: deprecated_member_use comment was added above cacheExtent in story_screen.dart. Since cacheExtent is not deprecated, this comment should be removed to avoid potential linter warnings or errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +857 to 858
// ignore: deprecated_member_use
cacheExtent: 300,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Flutter의 ListView.builder에서 cacheExtent 속성은 deprecated되지 않았습니다. 따라서 // ignore: deprecated_member_use 주석은 불필요하며, Dart linter 설정에 따라 unnecessary_ignore 경고나 에러를 유발하여 향후 CI가 다시 실패할 원인이 될 수 있습니다. 이 주석을 제거하는 것을 권장합니다.

Suggested change
// ignore: deprecated_member_use
cacheExtent: 300,
cacheExtent: 300,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant