Keep loading a profile under the name datasets recorded it as - #226
Merged
Conversation
Renaming jerm to seek would have stopped every dataset built against it from opening: a dataset stores the profile it was built with, the lookup would find nothing, and it would refuse to load rather than simply being labelled differently. Production could not be inspected to see whether any dataset uses the old name -- the site is up but SSH is unreachable -- and a breaking change to live data should not rest on an assumption. A rename is now a rename. An unknown profile still raises, so the mapping cannot turn a typo into a silent fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renaming
jermtoseek(#225) would have stopped every dataset built against it from opening. A dataset stores the profile it was built with; the lookup would find nothing and it would refuse to load — not merely appear under a different label.I could not check whether any production dataset uses the old name: the site responds 200 but SSH to the host is unreachable, so the database is not inspectable from here. A breaking change to live data should not rest on an assumption about that data.
SpecLoader.RENAMED_PROFILESmaps a previous name to the current one, consulted only after the direct lookup fails. So a rename is a rename, rather than a migration every dataset owner has to perform.An unknown profile still raises
SpecLoadError, so the mapping cannot turn a typo into a silent fallback — that is one of the three tests.2701 tests pass.