Skip to content

Investigate status bar double click issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonthepham-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Investigate status bar double click issue #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Rectangle/TitleBarManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,21 @@ class TitleBarManager {
}
lastEventNumber = event.eventNumber
if let toolbarFrame = windowElement.getChildElement(.toolbar)?.frame, toolbarFrame != .null {
titleBarFrame = titleBarFrame.union(toolbarFrame)
// Only include toolbars that are at the top of the window (near the title bar).
// Status bars at the bottom of windows (like in VSCode) are also exposed as toolbars
// but should not be included in the title bar detection area.
let currentWindowFrame = windowElement.frame
if currentWindowFrame != .null {
let windowHeight = currentWindowFrame.height
// In screenFlipped coordinates, maxY is the top edge
// Check if toolbar's top edge is near the window's top edge (within upper 30%)
let distanceFromTop = currentWindowFrame.maxY - toolbarFrame.maxY
// Consider toolbar as "top toolbar" if it's within the upper 30% of the window
// This prevents status bars at the bottom from being incorrectly included
if distanceFromTop >= 0 && distanceFromTop < windowHeight * 0.3 {
titleBarFrame = titleBarFrame.union(toolbarFrame)
}
}
}
guard
titleBarFrame.contains(location),
Expand Down