Fintek F81214E driver support#547
Open
gordon-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gordon-nexthop
changed the title
Author
|
Will wait for #541 and rebase accordingly |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gordon-nexthop
force-pushed
the
gordon.fintek_F81214E_driver_support
branch
from
6d02585 to
31b806e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saiarcot895
reviewed
Apr 4, 2026
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmenzel
suggested changes
Apr 10, 2026
| #define CHIP_ID_F81216AD 0x1602 | ||
| #define CHIP_ID_F81216E 0x1617 | ||
| #define CHIP_ID_F81216H 0x0501 | ||
| +#define CHIP_ID_F81214E 0x1417 |
Contributor
There was a problem hiding this comment.
I wonder why you didn’t put it below CHIP_ID_F81216, so it’s kind of sorted. But as it was accepted upstream, I guess the maintainer does not mind.
Contributor
|
Oh, and it’d be great, if you squashed all commits into one, and force pushed, so unnecessary commit messages get removed. |
gordon-nexthop
force-pushed
the
gordon.fintek_F81214E_driver_support
branch
from
2428678 to
b71acbe
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gordon-nexthop
force-pushed
the
gordon.fintek_F81214E_driver_support
branch
from
b71acbe to
8c055d5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
paulmenzel
suggested changes
Apr 11, 2026
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you. We are getting there. ;-)
- Use the correct name in the SONiC commit: Signed-off-by: gordon-nexthop gordon@nexthop.ai
- Maybe name in that commit, the device you tested on.
- Make the commit summary a statement: Add Fintek F81214E driver support
- Use the git.kernel.org URL of the commit in the merge/pull request description.
Tested on two configurations: 1. Fire Range CPU <--espi-->F81214E<-->AST2720 BMC 2. Fire Range CPU <--espi-->F81214E<-->front panel RJ45 Signed-off-by: gordon-nexthop <gordon@nexthop.ai>
Author
Hi Paul, thanks for the feedback. I’ve added changes for 2,3,4. Not entirely sure what you mean by point 1. Are you suggesting I change the contents of the patch file (line 2) to use my information as well, or are you suggesting a change to the signoff in the commit message? |
gordon-nexthop
force-pushed
the
gordon.fintek_F81214E_driver_support
branch
from
8c055d5 to
d01286d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver support for Finetk F81214E an LPC/eSPI to 2 UART Super I/O chip. Upstream linux commit to
tty-nextbranch - will remove this patch if and when this ultimately gets accepted and backported to 6.12.