Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .agents/skills/ce-plan/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,10 @@ Based on the origin document, user signals, and local findings, decide whether e

The repo-research-analyst output includes a structured Technology & Infrastructure summary. Use it to make sharper external research decisions:

- If specific frameworks and versions were detected (e.g., Next.js 16, NestJS 11, TypeORM 0.3), pass those exact identifiers to framework-docs-researcher so it fetches version-specific documentation
- If specific frameworks and versions were detected (e.g., Next.js 16, NestJS 11, Prisma 7), pass those exact identifiers to framework-docs-researcher so it fetches version-specific documentation
- If the feature touches a technology layer the scan found well-established in the repo (e.g., existing NestJS providers, repositories, or Next.js route patterns), lean toward skipping external research -- local patterns are likely sufficient
- If the feature touches a technology layer the scan found absent or thin (e.g., no existing proto files when planning a new gRPC service), lean toward external research -- there are no local patterns to follow
- If the plan touches Prisma in this repo, anchor the plan to `apps/api/package.json`, `apps/api/prisma.config.ts`, `apps/api/prisma/schema.prisma`, and `apps/api/src/prisma/prisma.service.ts`. Read `.agents/skills/prisma-cli/SKILL.md`, `.agents/skills/prisma-client-api/SKILL.md`, and `.agents/skills/prisma-database-setup/SKILL.md` before making ORM-specific recommendations
- If the scan detected deployment infrastructure (Docker, K8s, serverless), note it in the planning context passed to downstream agents so they can account for deployment constraints
- If the scan detected a monorepo and scoped to a specific service, pass that service's tech context to downstream research agents -- not the aggregate of all services. If the scan surfaced the workspace map without scoping, use the feature description to identify the relevant service before proceeding with research

Expand Down
14 changes: 7 additions & 7 deletions .agents/skills/ce-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ Focused TypeScript, frontend, API, reliability, and data-migration reviewers plu
| `compound-engineering:review:security-reviewer` | Auth, public endpoints, user input, permissions |
| `compound-engineering:review:performance-reviewer` | DB queries, data transforms, caching, async |
| `compound-engineering:review:api-contract-reviewer` | Routes, serializers, type signatures, versioning |
| `compound-engineering:review:data-migrations-reviewer` | TypeORM migrations, entity/schema changes, backfills |
| `compound-engineering:review:data-migrations-reviewer` | Prisma migrations, schema changes, backfills, data service updates |
| `compound-engineering:review:reliability-reviewer` | Error handling, retries, timeouts, background jobs |
| `compound-engineering:review:adversarial-reviewer` | Diff >=50 changed non-test/non-generated/non-lockfile lines, or auth, payments, data mutations, external APIs |
| `compound-engineering:review:previous-comments-reviewer` | Reviewing a PR that has existing review comments or threads |
Expand All @@ -129,14 +129,14 @@ Focused TypeScript, frontend, API, reliability, and data-migration reviewers plu

| Agent | Select when diff touches... |
|-------|---------------------------|
| `compound-engineering:review:kieran-typescript-reviewer` | TypeScript components, services, hooks, utilities, shared types, Nest providers, TypeORM repositories |
| `compound-engineering:review:kieran-typescript-reviewer` | TypeScript components, services, hooks, utilities, shared types, Nest providers, Prisma-backed repository wrappers |
| `compound-engineering:review:julik-frontend-races-reviewer` | React DOM events, timers, animations, or async UI flows |

**CE conditional (migration-specific):**

| Agent | Select when diff includes migration files |
|-------|------------------------------------------|
| `compound-engineering:review:deployment-verification-agent` | Produces deployment checklist with TypeORM / data rollout verification steps |
| `compound-engineering:review:deployment-verification-agent` | Produces deployment checklist with Prisma migration / data rollout verification steps |

## Review Scope

Expand Down Expand Up @@ -337,7 +337,7 @@ Read the diff and file list from Stage 1. The 4 always-on personas and 2 CE alwa

Stack-specific personas are additive. A Next.js UI change may warrant `kieran-typescript` plus `julik-frontend-races`; a NestJS API diff may warrant `kieran-typescript` plus `api-contract` and `reliability`.

For CE conditional agents, check if the diff includes TypeORM migration files, entity/schema transitions, or data backfill scripts.
For CE conditional agents, check if the diff includes Prisma migration files under `apps/api/prisma/migrations/`, schema transitions in `apps/api/prisma/models/*.prisma`, `apps/api/src/prisma/prisma.service.ts`, or data backfill scripts.

Announce the team before spawning:

Expand All @@ -349,8 +349,8 @@ Review team:
- project-standards (always)
- learnings-researcher (always)
- security -- new NestJS endpoint accepts a user-provided redirect URL
- data-migrations -- adds TypeORM migration `20260303-add-index-to-orders`
- deployment-verification-agent -- TypeORM migration or backfill files present
- data-migrations -- adds Prisma migration `apps/api/prisma/migrations/202604200001_add_feed_auto_refresh_state/migration.sql`
- deployment-verification-agent -- Prisma migration or backfill files present
```

This is progress reporting, not a blocking confirmation.
Expand Down Expand Up @@ -406,7 +406,7 @@ Each persona sub-agent returns JSON matching the findings schema included below:

**CE always-on agent** (`learnings-researcher`) is dispatched as a standard Agent call in parallel with the persona agents. Give it the same review context bundle the personas receive: entry mode, any PR metadata gathered in Stage 1, intent summary, review base branch name when known, `BASE:` marker, file list, diff, and `UNTRACKED:` scope notes.

**CE conditional agent** (`deployment-verification-agent`) is dispatched when the diff includes TypeORM migrations, data backfills, or risky entity/schema changes. Pass the same review context bundle plus the applicability reason.
**CE conditional agent** (`deployment-verification-agent`) is dispatched when the diff includes Prisma migrations, data backfills, or risky schema/data service changes. Pass the same review context bundle plus the applicability reason.

### Stage 5: Merge findings

Expand Down
6 changes: 3 additions & 3 deletions .agents/skills/ce-review/references/persona-catalog.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,16 @@ These reviewers keep their original opinionated lens. They are additive with the

## CE Conditional Agents (migration-specific)

These CE-native agents provide specialized analysis beyond what the persona agents cover. Spawn them when the diff includes TypeORM migrations, entity/schema changes, or data backfills.
These CE-native agents provide specialized analysis beyond what the persona agents cover. Spawn them when the diff includes Prisma migrations, schema changes, or data backfills.

| Agent | Focus |
|-------|-------|
| `compound-engineering:review:deployment-verification-agent` | Produces rollout, rollback, and verification guidance for TypeORM migrations and data changes |
| `compound-engineering:review:deployment-verification-agent` | Produces rollout, rollback, and verification guidance for Prisma migrations and data changes |

## Selection rules

1. **Always spawn all 4 always-on personas** plus the 2 CE always-on agents.
2. **For each cross-cutting conditional persona**, the orchestrator reads the diff and decides whether the persona's domain is relevant. This is a judgment call, not a keyword match.
3. **For each stack-specific conditional persona**, use file types and changed patterns as a starting point, then decide whether the diff actually introduces meaningful work for that reviewer. Do not spawn language-specific reviewers just because one config or generated file happens to match the extension.
4. **For CE conditional agents**, spawn when the diff includes TypeORM migration files, entity/schema transitions, or data backfill scripts.
4. **For CE conditional agents**, spawn when the diff includes Prisma migration files, schema transitions, or data backfill scripts.
5. **Announce the team** before spawning with a one-line justification per conditional reviewer selected.
244 changes: 0 additions & 244 deletions .agents/skills/ckm-design-system/SKILL.md

This file was deleted.

11 changes: 0 additions & 11 deletions .agents/skills/ckm-design-system/data/slide-backgrounds.csv

This file was deleted.

Loading