fix: send Authorization header when basicAuthPassword is empty string#53
Open
pglogowskisolidstudio wants to merge 1 commit into
Open
fix: send Authorization header when basicAuthPassword is empty string#53pglogowskisolidstudio wants to merge 1 commit into
pglogowskisolidstudio wants to merge 1 commit into
Conversation
The previous truthy check (`&&`) skipped the header when the password was an empty string. Use an explicit `!== undefined` check so the header is always sent when a password is configured. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pglogowskisolidstudio
force-pushed
the
fix/not-sending-auth-header
branch
from
a9eab19 to
0bc7ef2
Compare
dsokal
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authorizationheader was not sent whenbasicAuthPasswordwas set to an empty string&&) to an explicit!== undefinedcheck so the header is always included when a password is configuredTest plan
basicAuthPasswordto an empty string sends theAuthorizationheaderbasicAuthPassword(undefined) still skips the header🤖 Generated with Claude Code