perf: add SDF text layout cache and slim GlyphLayout#7
Merged
Conversation
Cache TextLayout results in a Map keyed by text properties to skip redundant generateTextLayout calls for nodes with identical config. Remove unused GlyphLayout fields (codepoint, glyphId, xOffset, yOffset) that the renderer never reads, reducing per-glyph memory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layoutCacheMap inSdfTextRendererthat cachesTextLayoutresults keyed by text properties (fontFamily, fontSize, letterSpacing, lineHeight, maxHeight, maxWidth, textAlign, text). SkipsgenerateTextLayoutentirely on cache hit.GlyphLayout(codepoint,glyphId,xOffset,yOffset) — verified these are never read byWebGlRenderer.addSdfQuadsor any other consumer.Motivation
Ported from upstream lightning-js/renderer@dbfd4e39. The layout cache avoids redundant glyph layout computation for text nodes with identical properties (e.g. repeated labels, list items). The GlyphLayout slimming reduces per-glyph object size by ~33%.
Test plan
vitest run)tsc --noEmit)🤖 Generated with Claude Code