chore: remove dead orphaned textures management#6
Merged
Conversation
The orphanedTextures set, addToOrphanedTextures(), and removeFromOrphanedTextures() are dead code — addToOrphanedTextures is never called anywhere, so the set is always empty and the remove call in CoreTextureManager.loadTexture() is a no-op. Cleanup already works via loadedTextures iteration. Mirrors lightning-js/renderer@383bce8. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orphanedTexturesset,addToOrphanedTextures(), andremoveFromOrphanedTextures()fromTextureMemoryManagerremoveFromOrphanedTextures()call inCoreTextureManager.loadTexture()Why
addToOrphanedTextures()is never called anywhere in the codebase, so theorphanedTexturesset is always empty. TheremoveFromOrphanedTextures()call inloadTexture()is a no-op. Memory cleanup already works correctly vialoadedTexturesiteration in thecleanup()method.Mirrors lightning-js/renderer@383bce8.
Test plan
tsc --noEmit)🤖 Generated with Claude Code