[fix] [subtexture] Update quad on subtexture node texture set#5
Merged
Merged
Conversation
chiefcll
approved these changes
May 8, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment
DIRTY_QUAD_BUFFER = trueProblem
When changing the texture prop of a node to a SubTexture whose atlas is already loaded (
isRenderable = true), the renderList is not invalidated (correct) however the quad is also not updated (incorrect).The result is that the texture does not change.
Solution
Update the quad of a subtexture when the texture value changes and the atlas texture was already loaded