Implement BEL control code event emission for decoupled bell handling - #8
Open
Chris-Moller wants to merge 2 commits into
Open
Implement BEL control code event emission for decoupled bell handling#8Chris-Moller wants to merge 2 commits into
Chris-Moller wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add onBell callback to Terminal that fires when BEL (0x07) is processed, with a visual bell handler in Renderer using CSS animation. The bell behavior is fully decoupled from the engine via the nullable callback pattern used throughout the codebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Implement BEL control code event emission for decoupled bell handling
Type: feature | Size: small | Priority: undefined
Description
Add BEL (ASCII 0x07) control code handling to the terminal engine that emits a bell event, allowing the UI layer to independently implement audio or visual responses. The parser already recognizes BEL as a C0 control code and routes it through
onExecute, and the terminal engine already has acase 0x07: // BELstub in_execute()that currently does nothing. This feature wires up a callback from that existing stub and optionally adds a visual bell handler in the UI/Renderer layer. This maintains clean separation of concerns between the engine and presentation layers.Acceptance Criteria
onBell) that fires when a BEL (0x07) character is processed in_execute().case 0x07stub insrc/terminal.jsinvokes the bell callback/event when triggered.Implementation Summary
Implemented BEL (0x07) control code event emission with onBell callback in Terminal, visual bell CSS animation in Renderer, and two passing tests
Completed:
Changed files:
src/terminal.jssrc/renderer.jssrc/mogterm.csstest/terminal.test.jsTests were run and passed.
Commits
Implemented by Venice Executor · task
8247ca3b-60ae-45b8-aa0b-983d9caec454